Programming

17668 readers

171 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Follow the programming.dev instance rules
Keep content related to programming in some way
If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev

founded 2 years ago

MODERATORS

snowe@programming.dev

Ategon@programming.dev

MaungaHikoi@lemmy.nz

How I got robbed of my first kernel contribution (ariel-miculas.github.io)

submitted 1 year ago by kairos@programming.dev to c/programming@programming.dev

50 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] ck_@discuss.tchncs.de 1 points 1 year ago (1 children)

I doubt the maintainer would even consider that the contributor would feel "belittled and angry"

... illustrating my point.

This whole article could have just been a report of "How I found a bug in the Kernel and helped fix it" - instead of something this negative

I disagree. If noone spoke out about Linus Torvalds calling people "dumb fucks", he would still be doing it. So criticism about how the community functions and which behavior is tolerated or even rewarded is essential if we ever want things to change. Did the author do the best job with this article? Probably not. That does not invalidate his experience though.

[–] RonSijm@programming.dev 2 points 1 year ago

This whole article could have just been a report of “How I found a bug in the Kernel and helped fix it” - instead of something this negative

I disagree. If noone spoke out about Linus Torvalds calling people “dumb fucks”, he would still be doing it.

It's kind of a leap from "not accepting a PR because the maintainer thought the code wasn't good enough to accept it at face value - and the maintainer apparently didn't care enough to give the contributor an extended code-review on how to fix it" vs "calling people “dumb fucks”"

If a maintainer get a PR that's bad and it would take an hour to write an explanation on how to fix it - and then hoping the end-result from the contributor is as expected, otherwise he'll have to write another explanation on how to fix it and go back and forth for a while - vs - just spending that hour rewriting the fix himself - I'm pretty sure most maintainers just do it themselves.

When you actually work for a company and you're working with other (junior) devs, you should go for the option of educating them on what's wrong with their PR... But in this case - I don't even know if the maintainer is doing this as a paid job or just in their spare time - but either way why would the maintainer spend time getting the PR right if it was apparently far off.

Did the author do the best job with this article? Probably not. That does not invalidate his experience though.

I didn't say his experience was invalid, but his experience probably isn't unusual. He could've taken this experience as "I contributed the QA and diagnosing part of this bugfix, but my code wasn't up to par. Next time before submitting some random fix for a bug that I found (that wasn't even "Up for grabs") (or discussed how it should be fixed at all) - I should contact the maintainer first" - Instead it seems he found a bug, didn't really report or communicate about it, because he wanted to race for a fix himself because he wanted to get recognition for actually creating the code the fixed the bug