this post was submitted on 06 Jan 2024
794 points (96.4% liked)

Programmer Humor

32721 readers
430 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] jjjalljs@ttrpg.network 4 points 11 months ago

We have one of those situations at work. We're a small team, but one guy is kind of unilateral in his work style. He added a bunch of "interfaces" and "domain" modules in our python Django app. His idea seems to be like instead of doing Project.object.get(id=1) with the standard Django library, you'd do like import project_interface; project_interface.get_project(id=1). The "interface" then does some home grown stuff, and probably delegates to the Django library eventually. All of which to me seems unnecessary, "yo dawg" redundant, and error prone.

Also in some places he's returning like a dict instead of query set or other Django object, which is going to cause problems later.

All of those specifics aside, because I'm sure he has reasons for all of this, but it's annoying that he's been doing it unilaterally. Worse, he had a project proposal to make the entire codebase like this and it was shot down. And every time it comes up in code reviews he's like "well, I think this is good and we don't have a standard saying otherwise".

I started really putting my foot down in places I have clear code ownership, but it still turns into like 30 comment exchanges on the pr.

He also has his own import sorting. Which could be fine except he never shared it or put it in the ci pipeline. So no one agreed to sort and comment imports like this, it's only in files he touched, and when other people change imports the comments become lies.

We have a standards meeting next week and I am not looking forward to it. We've been friendly for years and worked together before, but somehow at this job it's just not a smooth time.