this post was submitted on 29 Mar 2025
-26 points (33.3% liked)
Technology
68187 readers
3783 users here now
This is a most excellent place for technology news and articles.
Our Rules
- Follow the lemmy.world rules.
- Only tech related news or articles.
- Be excellent to each other!
- Mod approved content bots can post up to 10 articles per day.
- Threads asking for personal tech support may be deleted.
- Politics threads may be removed.
- No memes allowed as posts, OK to post as comments.
- Only approved bots from the list below, this includes using AI responses and summaries. To ask if your bot can be added please contact a mod.
- Check for duplicates before posting, duplicates may be removed
- Accounts 7 days and younger will have their posts automatically removed.
Approved Bots
founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
Yeah when I first started there was one guy whose code reviews I dreaded, he would nitpick every detail and he would stand by it, he would tell me to do it a completely different way that was 10x more work. It felt like I would never get my stories done because I had drawn "that asshole" in the code review lottery.
Years later, I came to realize that he was actually the best, he taught me so much about the way I should be thinking of things and structuring things, that have saved so much time and trouble later on, I now specifically reach out to him for a review when I am trying to do something complex because I know he's going to give me an honest, thorough and useful review. Nobody's doing anyone any favours in the long run by rubber stamping things, it may help you keep your sprint velocity up, but it's not going to result in high quality code, and the bad quality code will inevitably bite you.